Skip to content

London | 26-ITP-May | Russom Gebremeskel | Sprint 1 | Coursework#1384

Open
russom-g wants to merge 15 commits into
CodeYourFuture:mainfrom
russom-g:coursework/sprint-1
Open

London | 26-ITP-May | Russom Gebremeskel | Sprint 1 | Coursework#1384
russom-g wants to merge 15 commits into
CodeYourFuture:mainfrom
russom-g:coursework/sprint-1

Conversation

@russom-g

@russom-g russom-g commented Jun 22, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

By referring to documentation, syntax and other type of errors fixed. Some of the program code explained line by line.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026
Comment thread Sprint-1/2-mandatory-errors/3.js
Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js
Comment on lines 22 to +24
What is the return value of `prompt`?

- A text string that input by the user is returned. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user clicked "Cancel" instead of "OK"?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the code again and if "Cancel " clicked "null" is returned.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "null" you mentioned a string?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Because the user didn't type or input anything

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When you says "null" is returned, I wasn't sure if you were referring to null (a value representing 'nothing') or a string "null". So which null was you referring to?

  2. The user could type/input something and then clicked "Cancel". So it is not quite correct to say "the user didn't type or input anything".

Comment thread Sprint-1/4-stretch-explore/objects.md
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants